Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn 2 warning #57

Open
hacknug opened this issue Feb 5, 2020 · 2 comments
Open

Yarn 2 warning #57

hacknug opened this issue Feb 5, 2020 · 2 comments
Assignees
Labels
👍good first issue Good for newcomers 😥help wanted Extra attention is needed

Comments

@hacknug
Copy link
Member

hacknug commented Feb 5, 2020

I was just trying out Yarn 2 to see if there were any major issues with Gridsome and got this warning:

eslint-plugin-gridsome@npm:1.4.0 doesn't provide eslint@^5.0.0 || ^6.0.0 requested by vue-eslint-parser@npm:6.0.5

Guessing eslint should be listed either in dependencies or peerDependencies? 🤔

@tyankatsu0105 tyankatsu0105 self-assigned this Feb 10, 2020
@tyankatsu0105 tyankatsu0105 added 👍good first issue Good for newcomers 😥help wanted Extra attention is needed labels Feb 10, 2020
@tyankatsu0105
Copy link
Member

@hacknug
Umm...
Maybe we need to add engines to package.json.
Like this:

{
  "engines": {
    "yarn": "^1.22.0"
  }
}

1.22.0 is current's stable version of Yarn.

@hacknug
Copy link
Member Author

hacknug commented Feb 10, 2020

I don't think that's the way to solve it since people should (ideally) be able to also use npm and pnpm to manage their dependencies.

Guessing eslint should be listed either in dependencies or peerDependencies? 🤔

I think it's related to how deps are listed, like I mentioned. Maybe @hjvedvik can help us out here since he probably has more experience dealing with this things than I do haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍good first issue Good for newcomers 😥help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants