Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atty potential unalined read #67

Open
greymd opened this issue Jan 2, 2024 · 1 comment
Open

atty potential unalined read #67

greymd opened this issue Jan 2, 2024 · 1 comment

Comments

@greymd
Copy link
Owner

greymd commented Jan 2, 2024

This bug is created from a dependabot alert
Screenshot 2024-01-02 at 19 28 43

Following crates are using atty internally.

  • env_logger 0.7.1
  • structopt v0.3.26
  • criterion v0.3.6
$ cargo tree | grep -C 5 atty
teip v2.3.0 ..
├── cfg-if v0.1.10
├── env_logger v0.7.1
│   ├── atty v0.2.14
│   │   └── libc v0.2.139
│   ├── humantime v1.3.0
│   │   └── quick-error v1.2.3
│   ├── log v0.4.17
│   │   └── cfg-if v1.0.0
--
│           ├── quote v1.0.23 (*)
│           └── unicode-ident v1.0.6
└── structopt v0.3.26
    ├── clap v2.34.0
    │   ├── ansi_term v0.12.1
    │   ├── atty v0.2.14 (*)
    │   ├── bitflags v1.3.2
    │   ├── strsim v0.8.0
    │   ├── textwrap v0.11.0
    │   │   └── unicode-width v0.1.10
    │   ├── unicode-width v0.1.10
--
│   │   ├── predicates-core v1.0.5
│   │   └── termtree v0.4.0
│   └── wait-timeout v0.2.0
│       └── libc v0.2.139
└── criterion v0.3.6
    ├── atty v0.2.14 (*)
    ├── cast v0.3.0
    ├── clap v2.34.0 (*)
    ├── criterion-plot v0.4.5
    │   ├── cast v0.3.0
    │   └── itertools v0.10.5 (*)

I will try to upgrade those crates and see if this alert is gone or not.

greymd added a commit that referenced this issue Jan 2, 2024
As mentioned GitHub Issue #67, `atty` crate would have potential unalined pointer.
@greymd
Copy link
Owner Author

greymd commented Jan 2, 2024

structopt is in maintainance mode. We need to replace it to clap to remove atty.
https://github.com/TeXitoi/structopt

@greymd greymd changed the title Update depending crates atty potential unalined read Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant