Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IfExistsResult is not a boolean #6

Closed
Mike-Crowley opened this issue Apr 12, 2024 · 6 comments
Closed

IfExistsResult is not a boolean #6

Mike-Crowley opened this issue Apr 12, 2024 · 6 comments

Comments

@Mike-Crowley
Copy link
Contributor

In the readme you say:

When the account does not exist, IfExistsResult is set to 0.

However this is not correct. IfExistsResult is described here.

-1 An unknown error
0 The account exists, and uses that domain for authentication
1 The account doesn’t exist
2 The response is being throttled
4 Some server error
5 The account exists, but is set up to authenticate with a different identity provider. This could indicate the account is only used as a personal account
6 The account exists, and is set up to use both the domain and a different identity provider
@abbbe
Copy link
Contributor

abbbe commented Apr 12, 2024

Can you make a bugfix?

@Mike-Crowley
Copy link
Contributor Author

PR per request:
#7

@Mike-Crowley
Copy link
Contributor Author

You may also wish to review these lines of code:

https://github.com/gremwell/o365enum/blob/master/o365enum.py#L161-L164

and determine if they should be re-written. It depends if you want to add functionality or not.

@Mike-Crowley
Copy link
Contributor Author

@abbbe did you need anything further on this one?

@abbbe
Copy link
Contributor

abbbe commented May 2, 2024 via email

@Mike-Crowley
Copy link
Contributor Author

Mike-Crowley commented May 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants