Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives when case-insensitive unique indexes have CITEXT strings #167

Open
gee-forr opened this issue Jan 15, 2024 · 1 comment · May be fixed by #168
Open

False positives when case-insensitive unique indexes have CITEXT strings #167

gee-forr opened this issue Jan 15, 2024 · 1 comment · May be fixed by #168

Comments

@gee-forr
Copy link

gee-forr commented Jan 15, 2024

Hi there,

Thanks for this great gem. It's such a useful tool and we love it.

I noticed that when I run it against a postgres db that has a unique index on a Postgres Case Insensitive Text (CITEXT) string, it still recommends creating an index using the lower(column_name) function.

My understanding is that using a CITEXT field removes the need for using lower() in the index.

@gregnavis Would you be keen on me submitting a PR to avoid this false positive?

@fatkodima
Copy link
Contributor

Your understanding is correct. Please open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants