Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirestoreDocument is returning data from an id that doesn't exist #62

Open
tammyhart opened this issue Jun 29, 2020 · 0 comments
Open

Comments

@tammyhart
Copy link

  • react-firestore version: 0.8.1 (from getfirefly.org)
  • node version: 12.13.1
  • npm (or yarn) version: 6.13.6

Relevant code or config

<FirestoreDocument path={`posts/${match.params.id}`}>

What you did: Query a document with an id that doesn't exist.

What happened:

Instead of getting an error (necessary for displaying a 404), it just returns the data with the id I provided it.
Screen Shot 2020-06-29 at 5 33 12 PM

Suggested solution: Provide an error when the document isn't found.

@tammyhart tammyhart changed the title FirestoreDocument is returning data from an i that doesn't eist FirestoreDocument is returning data from an id that doesn't exist Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant