fix(deepEqual.js): add equality check using isEqual Doc refs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
green-arrow
requested changes
Jun 5, 2018
| @@ -23,3 +23,32 @@ test('returns true if nested arrays are the same', () => { | |||
| test('returns false if nested arrays are different', () => { | |||
| expect(deepEqual(['a', ['b', ['c']]], ['d', ['e', ['f']]])).toBe(false); | |||
| }); | |||
|
|
|||
| function mockIsEqual(other) { | |||
| return this.value === other.value; | |||
There was a problem hiding this comment.
@cdock1029 - Looks like the tests are failing due to the eslint no-invalid-this rule. I think adding an ignore here for this rule would be fine.
bfirsh
added a commit
to bfirsh/boxwise
that referenced
this pull request
Jun 19, 2018
Fixed by green-arrow/react-firestore#23 My branch is that pull request rebased on master, which has some fixes we need.
rubenspgcavalcante
pushed a commit
to boxwise/boxwise
that referenced
this pull request
Jun 20, 2018
Fixed by green-arrow/react-firestore#23 My branch is that pull request rebased on master, which has some fixes we need.
|
@cdock1029 - I'm going to go ahead and close this since the build is not passing. If you have time to update this PR feel free to reopen it! @bfirsh - Feel free to make another PR with this change if you'd like 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #22