Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using a reference in a filter, FirestoreCollection reloads on every render #22

Open
bfirsh opened this issue Jun 2, 2018 · 0 comments
Open

When using a reference in a filter, FirestoreCollection reloads on every render #22

bfirsh opened this issue Jun 2, 2018 · 0 comments

Comments

@bfirsh
Copy link
Contributor

bfirsh commented Jun 2, 2018

E.g. when doing filter={["thing", "==", db.doc("things/" + thing)]}. I think this is because deepEqual thinks they’re always different, but I haven’t investigated in detail.

See also #19
cdock1029 added a commit to cdock1029/react-firestore that referenced this issue Jun 4, 2018
@cdock1029
fix(deepEqual.js): add equality check using isEqual method for Docume…
e57746d 
…nt references

fix green-arrow#22
@cdock1029 cdock1029 mentioned this issue Jun 4, 2018
Closed
bfirsh pushed a commit to bfirsh/react-firestore that referenced this issue Jun 19, 2018
@cdock1029 @bfirsh
fix(deepEqual.js): add equality check using isEqual method for Docume…
db67c94 
…nt references

fix green-arrow#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deepEqual.js): add equality check using isEqual Doc refs cdock1029/react-firestore
1 participant
@bfirsh