Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #11

Open
alexstrat opened this issue Mar 28, 2018 · 1 comment
Open

Typescript support #11

alexstrat opened this issue Mar 28, 2018 · 1 comment

Comments

@alexstrat
Copy link

If someone (me or anyone else) would like to add Typescript support to react-firestore, would you prefer:

  1. the whole project to be migrated to Typescript, or
  2. an independent type definition to be maintained via DefinitelyTyped.

From a TS user perspective the solution 1/ is preferable since it prevents type definition to drift appart from actual library but it requires that the library is maintained in TS (which has numerous benefits :))

👋

@green-arrow
Copy link
Owner

@alexstrat - Although it would be preferable to use typescript in the project for typescript consumers, I believe it would require pretty significant effort to the build system. Currently we use kcd-scripts to build the project, and moving to typescript would mean we could no longer use that and would have to create a custom build. For that reason I'd prefer an independent type definition. We could also add types for flow as well.

Thanks for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants