Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify why the new Download permission is needed #2961

Closed
Powersource opened this issue May 23, 2018 · 5 comments
Closed

Clarify why the new Download permission is needed #2961

Powersource opened this issue May 23, 2018 · 5 comments

Comments

@Powersource
Copy link

So firefox just told me that I need to accept the new permission that greasemonkey requires to update it:
"Download files and read and modify the browser's download history"

I didn't see it mentioned in the blogpost so I thought I'd ask.

@Sxderp
Copy link
Contributor

Sxderp commented May 23, 2018

For exporting the database. It's much simpler to utilize the Downloads API to initiate the save request. It's possible to do without but the code is not quite as clean. Honestly there should be a 'save this file' API (that prompts the user) that doesn't require Downloads permissions, but unfortunately there isn't.

@arantius
Copy link
Collaborator

That.

@eight04
Copy link

eight04 commented May 24, 2018

In Firefox >= 60, downloads could be put in optional_permissions:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/optional_permissions

@arantius arantius reopened this May 24, 2018
@arantius arantius added this to the 4.5 milestone May 24, 2018
@arantius
Copy link
Collaborator

I want to do other Fx-60-minimum changes in the next release anyway, so that sounds great.

@arantius
Copy link
Collaborator

Oh, #2962

@arantius arantius removed this from the 4.5 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants