New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider implementing GM_registerMenuCommand in GM 4.x #2714
Comments
For reference, I quote the relevant discussion from #2559 : (eight04)
(arantius)
(eight04)
(arantius)
(eight04)
(trlkly)
|
This gives me a headache trying to think about how the scripts would interact. Assuming there was a menu option and said menu option opened some sort of window / box / dialog / whatever to change settings, is that newly generated window considered to be in the 'content script' context and therefore able to send messages to the extension? And if it's not then how does one send a message back to the content script, so that settings can be changed? Though, it seems that a common theme is settings menus. I'd be in favor of having staticly defined configuration fields in the metablock that are then generated and can be saved / modified through the Monkey menu. Similar to a |
I'm afraid that using static configuration fields in the metablock would make it too limiting:
Plus, its author should have to rewrite the entire 'setup code. |
FWIW, W3C removed context menu from HTML5, and Firefox is going to remove it as well. |
@legnaleurc Gosh, that could be an issue for some people. As a total layman, I have no idea, but do you happen to know of an alternative way to add context menu items, to replace the method that uses ? Is there some simple method I am not aware of that's usable from a userscript? |
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves one part of greasemonkey#2714 .
Resolves greasemonkey#3078 , greasemonkey#3099 , and one part of greasemonkey#2714 .
Done in #3078 |
Thank you. |
As I saw (see comment)
GM_registerMenuCommand
is replaced with HTML5 context menu. and there's no plan to add it in GM 4.x.Nevertheless, I've started this separate issue. in hope that you'll might reconsider.
I understand that adding some context menu options in the native context menu,
is useful for those that do want to add more entries in that.
Such as this new test script by arantius search-with-google.
screenshots:
But, for userscripts that use
GM_registerMenuCommand
only for settings, i.e. you only configure then only once in a while.and apply to all pages,
such as the popular:
Mouseover Popup Image Viewer, (settings screenshot)
YouTube Link Title (settings screenshot) and
Linkify Plus Plus (settings screenshot )
Imagine having installed these scripts that create a total of 3 entries on top of the context menu
that are not needed most of the time:
it would make use the context menu on the page cluttered and unpractical.
And then the script author, in order to avoid cluttering the context menu just for the sake for offering settings,
he would either register a keyboard shortcut on every page (with no UI?)
or create a new dedicated button element on every page.
So, I'd like to ask you please to reconsider implementing
GM_registerMenuCommand
inside the toolbar button popup, similar to how it was in GM 3.x, as well as in the other most used scripts managers available, Tampermonkey and Violentmonkey.,
It would appear between/below the "Greasemonkey is active/disabled" entry,
and above the 'User scripts for this tab' list (GM 4.1 beta4).
The text was updated successfully, but these errors were encountered: