Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons for amenity=waste_disposal and amenity=waste_basket #4914

Open
Dimitar5555 opened this issue Dec 8, 2023 · 3 comments
Open

Comments

@Dimitar5555
Copy link

Expected behavior

amenity=waste_disposal should be rendered with something similar to a dumpster/large container. amenity=waste_basket should be rendered with something that looks like a waste basket.

Actual behavior

Currently amenity=waste_disposal is rendered with the same icon as amenity=waste_basket but with minor diffrences (one of them being their size). amenity=waste_basket is rendered using an icon that looks like a cremation pot/flower pot with a lid.

iD seems to use nice icons for both of them. I'm not sure if they can be used directly but they are a good inspiration.
amenity=waste_basket: https://github.com/mapbox/maki/blob/main/icons/waste-basket.svg
amenity=waste_disposal: https://fontawesome.com/v5/icons/dumpster?f=classic&s=solid

Screenshots with links illustrating the problem

Current rendering:
image
iD icons:
image

@imagico
Copy link
Collaborator

imagico commented Dec 8, 2023

Thanks for looking at the waste icons. These indeed could use some refinement work.

I don't quite understand your critique and suggestion though. Here current symbols we use and the maki waste basket symbol mentioned in comparison:

waste

  • the maki symbol is - apart from the rounded corners and the more detailed handle on the lid - more or less exactly the same shape as the symbol we use - except larger.
  • if you'd use the larger waste baket symbol that would mean no size differentiation towards amenity=waste_disposal (not to mention a very crowded map in areas with many waste baskets). And there is no substantial room to increase the size of the amenity=waste_disposal symbol within our 14x14 pixel standard (shown in the illustration).
  • our symbol guidelines mandate a simple siloutte of the subject with an "on the shelf" perspective - so perspective views are not seen very favorably.
  • at 14 pixel size the suggested dumpster symbol is not recognizable IMO.

@dch0ph
Copy link
Contributor

dch0ph commented Dec 8, 2023

Agree with the general point that amenity=waste_disposal is poorly differentiated from amenity=waste_basket, as the example shows.

From a brief look, it is not straightforward to simply re-use the font awesome icons as iD does. iD can and does use larger icons (16 x 16?) for a start.

A simplified version of the font awesome "dumpster" might work. Wide rather than tall would visually differentiate from waste_basket and a simple flat lid with no handle (avoiding the perspective aspect)?

Personally I don't think the maki wastebasket looks good. It looks like a cup with a generous cappuccino! The FA symbol is more recognisable.

@Dimitar5555
Copy link
Author

I don't quite understand your critique and suggestion though.

For waste baskets we use a tiny pot and for dumpsters we use a waste basket. The easiest solution seems be to use the current icon for waste_collection on waste_basket and think of another icon for the dumpsters.

A simplified version of the font awesome "dumpster" might work. Wide rather than tall would visually differentiate from waste_basket and a simple flat lid with no handle (avoiding the perspective aspect)?

I've tried to draw a dumpster but it's 16x16. 14x14 doesn't seem to work like I want it to:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants