Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render junction=roundabout like oneway=yes #467

Closed
sb12 opened this issue Apr 9, 2014 · 13 comments · Fixed by #1393
Closed

Render junction=roundabout like oneway=yes #467

sb12 opened this issue Apr 9, 2014 · 13 comments · Fixed by #1393

Comments

@sb12
Copy link
Contributor

sb12 commented Apr 9, 2014

According to the wiki junction=roundabout implies oneway=yes.
Therefore, I propose to render all highways with junction=roundabout and oneway!=no in the same way as oneway ways.

@matthijsmelissen
Copy link
Collaborator

See also #465 (the code there solves part of the problem here).

Not sure if we want to implement this, though. Opinions?

@matthijsmelissen
Copy link
Collaborator

@pnorman @gravitystorm What do you think?

@matthijsmelissen
Copy link
Collaborator

Any opinions?

@pnorman
Copy link
Collaborator

pnorman commented May 28, 2014

I'm skeptical about "implied" values, particularly solely based on wiki documentation. Leaving that aside, something to watch for is oneway arrows appearing at relatively low zooms where the roundabout itself is quite small, you do not want this. The arrows only add value when the zoom is high enough to see within the roundabout

@dieterdreist
Copy link

2014-05-28 2:59 GMT+02:00 Paul Norman notifications@github.com:

I'm skeptical about "implied" values, particularly solely based on wiki
documentation.

I think for roundabouts it is broadly accepted that the tag
junction=roundabout conveys also the oneway-implication. This is btw. also
how it works with traffic signs (roundabouts are all oneways, but there is
never a oneway-sign, at least not in the ones I know of). This is not valid
for all circular roads of course, but for true roundabouts it should be.

You see this reflected also in the current tools like JOSM validator etc.
not only in the wiki, and I know from discussions on the local ML that
people actively remove oneway=yes tags from roundabouts.

Leaving that aside, something to watch for is oneway arrows appearing at
relatively low zooms where the roundabout itself is quite small, you do not
want this. The arrows only add value when the zoom is high enough to see
within the roundabout

yes, but this is a different issue.

@matkoniecz
Copy link
Contributor

Developers of iD editor consider that there is "assumed default of oneway=yes on things like junction=roundabout and highway=motorway"

See openstreetmap/iD#2220

See https://github.com/bhousel/iD/blob/master/js/id/core/oneway_tags.js for set of tags that according to iD editor implies onewayness.

@Rovastar
Copy link
Contributor

I think it is safe to assume they are one way.
if on the crazy edge case counter example they are not they can be tagged one-way= no and it would not render

@matthijsmelissen
Copy link
Collaborator

So we seem to agree that roundabouts should be assumed to be oneway. Next question: does it make sense to render arrows on them?

@chrisfleming
Copy link
Contributor

From a map point of view, I don't think it's necessary to render arrows on them, as most people will see a roundabout and know that it's one way. The only exception would be larger cases where it might not be so obvious if something is a roundabout or a 2 way road.

The other advantage would be that having the arrows on roundabouts would point people to fix cases where the roundabout direction is wrong.

@dieterdreist
Copy link

2014-05-29 13:01 GMT+02:00 Chris Fleming notifications@github.com:

From a map point of view, I don't think it's necessary to render arrows on
them, as most people will see a roundabout and know that it's one way. The
only exception would be larger cases where it might not be so obvious if
something is a roundabout or a 2 way road.

you cannot see from the rendering if something is a roundabout or not,
because we do not render any icon or style particular to roundabouts. You
will see a circle road and can only guess it could be a roundabout.

@gravitystorm
Copy link
Owner

I'm in favour of oneway arrows on roundabouts (those without oneway=no, of course), as per the original request.

@matthijsmelissen
Copy link
Collaborator

@Rovastar
Copy link
Contributor

Rovastar commented Jun 3, 2014

I was not clear in my above comments but I am in favor too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment