Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop rendering name on waterway=riverbank and water=river areas #4487

Open
matkoniecz opened this issue Oct 22, 2021 · 4 comments
Open

Stop rendering name on waterway=riverbank and water=river areas #4487

matkoniecz opened this issue Oct 22, 2021 · 4 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 22, 2021

Expected behavior

name on water=river areas is not rendered, the same way names on waterway=riverbank is not rendered

Actual behavior

Currently this labels are rendered what may mislead mappers and encourage them to map this way

Links and screenshots illustrating the problem

https://www.openstreetmap.org/#map=17/51.31935/15.00390

screen01

See also https://josm.openstreetmap.de/ticket/21461

@imagico
Copy link
Collaborator

imagico commented Oct 22, 2021

This would be good to combine with #3896/#4128 so mappers better understand why certain water polygons get a label while others do not.

@DaveF63
Copy link

DaveF63 commented Mar 24, 2022

Similar for water=canal, stream & all other linear water areas.

@pnorman
Copy link
Collaborator

pnorman commented Jul 10, 2022

We actually do this for waterway=riverbank already. It's just natural=water water=river (and canal, etc) which are new tags and so don't have support. I've edited the original issue.

I also had a look at fixing this, but my inclination was to pull water area labels out of amenity-points and into their own layer.

@DaveF63
Copy link

DaveF63 commented Jul 10, 2022

That natural=water schema is described as "new" shows how outdated OSM-Carto is. Changing the labelling rule for these tags shouldn't even require discussion. The two tagging schemas have precisely the same meaning, they are like-for-like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants