Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highway ref's with long modifiers should be rendered #4438

Open
elijahmathews opened this issue Jul 10, 2021 · 4 comments
Open

Highway ref's with long modifiers should be rendered #4438

elijahmathews opened this issue Jul 10, 2021 · 4 comments

Comments

@elijahmathews
Copy link

Expected behavior

Highway ways should have the values of their ref tags rendered.

Actual behavior

Highway ways with ref tags that contain long modifiers (e.g. ref=US 81 Business or ref=ND 200 Alternate) are not having their ref's rendered. They are rendered if the modifiers are abbreviated (e.g. ref=US 90 ALT), but that probably goes against the no abbreviations convention.

Some abbreviations that are known to be used:

  • ref=... Businessref=... BUS or ref=... Bus
  • ref=... Alternateref=... ALT or ref=... Alt
  • ref=... Bypassref=... BYP
  • ref=... Truckref=... TRK

Links and screenshots illustrating the problem

In Grand Forks, ND, 32nd Avenue South is (probably correctly) tagged with ref=US 81 Business but has no ref rendered, unlike the nearby interstate with ref=I 29;US 81:
ex1

Meanwhile, in East Bernard, TX, Main Street is (probably incorrectly) tagged with ref=US 90 ALT and has its ref rendered as expected:
ex2

@imagico
Copy link
Collaborator

imagico commented Jul 10, 2021

Length limit is 11 characters, determined on the longest ref:

WHERE height <= 4 AND width <= 11

The concern about this creating bad mapping incentives is valid, i am not sure if the solution can be to maintain a list of abbreviations in all languages of the world (at least not within this style - it could be a valuable idea for a separate project - like also for abbreviations in other labels like street names). The alternative would be to apply some generic shortening using an ellipsis like suggested for addresses already: #4160 (comment)

@elijahmathews
Copy link
Author

I suppose even if there were to be some sort of abbreviation lookup table that was used solely for the purpose of rendering highway ref's, that wouldn't necessarily negate bad mapping practices as mappers would presume the displayed labels' format (i.e. a rendered label along the lines "US 81 BUS") is exactly how the ref values should be formatted (i.e. ref=US 81 BUS rather than ref=US 81 Business). The ellipsis (or even just a period) method would probably be better in that case since it would make it clearer there's an abbreviation taking place, although some modifier abbreviations wouldn't work as well in that scheme (e.g. "Truck" is probably better abbreviated as "Trk..." or "Trk." rather than "Tru..." or "Tru.").

To me, perhaps the best scenario would be to add a new tag along the lines of ref:abbr=* (and multilingual versions like ref:es:abbr=*) to allow mappers to explicitly set the abbreviated version of the ref, which renderers would look to first if it's used or else defer to ref. However, this would mostly add redundant information to the map, you'd still get some ref:abbr values that would probably exceed the 11 character limit (e.g. if a hypothetical but not that unreasonable highway ref:abbr=ND 1804B ALT existed), and it necessarily enforces one particular abbreviation scheme.

@Adamant36
Copy link
Contributor

To me, perhaps the best scenario would be to add a new tag along the lines of ref:abbr=*

There's currently the tag short_name for abbreviated names. Short_ref also exists, but unfortunately it only has 7 uses. That said, it might be worth turning into a proposal and advocating somewhere for wider usage of it.

@jeisenbe jeisenbe changed the title Not rendering highway ref's with long modifiers Highway ref's with long modifiers should be rendered Sep 19, 2021
@ZeLonewolf
Copy link
Contributor

Note this would be made redundant if #508 is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants