Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: turning circles on private track roads coloured wrong #4334

Open
k-yle opened this issue Feb 21, 2021 · 8 comments
Open

bug: turning circles on private track roads coloured wrong #4334

k-yle opened this issue Feb 21, 2021 · 8 comments
Labels

Comments

@k-yle
Copy link

k-yle commented Feb 21, 2021

Expected behaviour

Turning circles on track roads with access=private should be the same colour as the track (#e9dcce if private, #996600 if public).

Actual behaviour

Turning circles always use #996600, even if the way and node have access=private.

This stands out a lot and looks like a tagging error.

image

Links and screenshots illustrating the problem

See screenshot above. Source: here, also here

@imagico
Copy link
Collaborator

imagico commented Mar 3, 2021

Note drawing the turning circle with the private access color could be confused with urban landuse fills. But in general this indeed should be fixed in some form.

@imagico imagico added the roads label Mar 3, 2021
@pnorman
Copy link
Collaborator

pnorman commented Jul 16, 2022

I find the highway=turning_circle rendering for tracks poor in general, standing out too much. I would be in favour of removing it and only showing turning circles for roads rendered with the thick fill + thin casing as opposed to the style of tracks, cycleways, footways, etc.

@imagico
Copy link
Collaborator

imagico commented Jul 16, 2022

Until #4096 we rendered highway=track polygons with a lighter brown fill - see #4096 (review) - that would be a suitable starting point for changing the turning circle design.

In the ac-style i use a similarly light brown fill for both turning circles and ground unit rendering (details):

ac-style

Practically turning circles for tracks are pretty common and pretty meaningful for map users since many tracks are too narrow to turn around on the way. Providing feedback to where they are mapped and where not is highly beneficial. Let's not further turn this into a urban focus style by further neglecting and dropping rural features.

@k-yle
Copy link
Author

k-yle commented Dec 9, 2022

another oddity with turning circles, underground ones look weird.

@imagico
Copy link
Collaborator

imagico commented Dec 10, 2022

This has nothing to do with track roads so please open a separate issue (and provide links to the examples).

(this is related to #2558 - for tunnels it is still a separate problem).

@k-yle
Copy link
Author

k-yle commented Dec 10, 2022

okay, i've opened #4747. You can click the examples above to see the osm feature

@romwriter
Copy link

This is a duplicate of #340, isn't it?

@imagico
Copy link
Collaborator

imagico commented Jan 14, 2023

Not quite. #340 was about access restriction dashing - and was closed because rendering such correctly on turning circles (which are currently rendered in layers separate from the linear roads and road polygons) is hard and would mean significant additional complexity. This would only be a possibility based on a solution for #2046 - which however conflicts with #3281.

This specific problem however can be solved within the existing layer structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants