Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add OSMC Symbols to route relations #3792

Closed
kolgza opened this issue May 29, 2019 · 9 comments
Closed

Feature Request: add OSMC Symbols to route relations #3792

kolgza opened this issue May 29, 2019 · 9 comments
Labels
Milestone

Comments

@kolgza
Copy link
Contributor

kolgza commented May 29, 2019

OSMC Symbols allow way-markers to be saved in a machine readable format. These is extremely useful for hiking and mountain biking. If Carto supported them, then it would drive their adoption.

@matkoniecz
Copy link
Contributor

If Carto supported them

openstreetmap-carto is style used to generate human-readable image from OSM data. I am unsure how support of them would look like.

OSM data itself is already machine-readable (and generally human-readable).

OSMC Symbols

It seems to be link to page describing something unrelated ("alternate routes which did not lead into the congested Golden Triangle")

@mboeringa
Copy link

It seems to be link to page describing something unrelated ("alternate routes which did not lead into the congested Golden Triangle")

It likely should have referred to pages like these:
https://wiki.openstreetmap.org/wiki/Key:osmc:symbol
https://www.wanderreitkarte.de/symbols_en.html

@matkoniecz
Copy link
Contributor

I am pretty sure that there is no enough space to display trails in addition to other data. Even waymarkedtrails.org is not doing this and they have multiple separate views.

@kolgza
Copy link
Contributor Author

kolgza commented May 29, 2019

I'm not necessarily talking about highlighting each route. I just think that it's important for Carto to at-least support the symbols, but not necessarily highlight the routes. The symbols are too significant to not be displayed.

@pkoby
Copy link

pkoby commented May 31, 2019

This is similar to displaying highway route shields, but probably on a smaller scale. I wouldn't display these beyond a certain high zoom level (z17?). I do like the idea of adding them in, though.

@Adamant36
Copy link
Contributor

There was an issue here somewhere a while back about rendering America specific highway route shields, but it was roundly rejected as to detailed for a detailed map. Unfortunately, I can't remember where it was now. This might fall under that since it's not universally used. Although, personally I think support for both would be cool and maybe encourage more mappers in America.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Jun 1, 2019

This key osmc:symbol is used 82,000 times on relations, presumably of type=route as recommended on the wiki page. https://wiki.openstreetmap.org/wiki/Key:osmc:symbol

Unfortunately, we probably can't currently render reference numbers or symbols that are properly tagged on route relations, because the tool that we use to import data for rendering, osm2pgsql, does not handle these relations in a useful way. I believe this would prevent us from rendering these symbols at this time.

See this issue for more details: #596
And this closed PR: #3663
Issue about extending osm2pgsql: osm2pgsql-dev/osm2pgsql#230

@pnorman
Copy link
Collaborator

pnorman commented Jun 20, 2019

There was an issue here somewhere a while back about rendering America specific highway route shields, but it was roundly rejected as to detailed for a detailed map.

No, #508 is open, but depends on the #596 which is difficult or impossible with current architecture.

OSMC Symbols allow way-markers to be saved in a machine readable format. These is extremely useful for hiking and mountain biking. If Carto supported them, then it would drive their adoption.

Do you have any examples of them being parsed in Lua or in SQL + CartoCSS?

@pnorman
Copy link
Collaborator

pnorman commented Jun 20, 2019

Unfortunately, we probably can't currently render reference numbers or symbols that are properly tagged on route relations

We'd have no problems here because there's no duplication with on-way data.

@jeisenbe jeisenbe added the roads label Aug 24, 2019
@jeisenbe jeisenbe added this to the New features milestone Nov 10, 2019
@jeisenbe jeisenbe changed the title Feature Request: Support for OSMC Symbols Feature Request: add OSMC Symbols to route relations Nov 10, 2019
@kolgza kolgza closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants