Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to a new Mapnik and Kosmtik versions #3717

Closed
kocio-pl opened this issue Mar 14, 2019 · 8 comments
Closed

Update to a new Mapnik and Kosmtik versions #3717

kocio-pl opened this issue Mar 14, 2019 · 8 comments

Comments

@kocio-pl
Copy link
Collaborator

Expected behavior

After upgrade to newest Kosmtik version from git master (see kosmtik/kosmtik#295) rendering should not change.

Actual behavior

There are some warnings and the rendering is broken.

Links and screenshots illustrating the problem

Example warnings:

Warning: landcover.mss:608:6 Styles do not match layer selector #landcover-low-zoom.
Warning: landcover.mss:608:6 Styles do not match layer selector #landcover.

Luxembourg - after:

YRC5B9M2

@kocio-pl
Copy link
Collaborator Author

This change is needed to finally merge long awaited #3399.

@pnorman
Copy link
Collaborator

pnorman commented Mar 15, 2019

If we require a new mapnik version we should be doing that in a major release

@matthijsmelissen
Copy link
Collaborator

After upgrade to newest Mapnik version from git master

It's either master or the latest (version) tag, it cannot be both :)

Does OSMF Operations already run the latest version? Logistically it would probably be easier if they bump their version first, before we release a version requiring the new Mapnik.

@sommerluk
Copy link
Collaborator

On my local machine, it renders correctly. But I have deleted all .index files for the shapefiles. I suspect these files make problems because there is a version missmatch between the Mapnik version that generates the index files (either the downloaded index files or these you might re-create locally using your distribution's Mapnik package) and the node-mapnik version used by Kosmtik. If you delete the index files, does it render correctly?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 6, 2019

I have upgraded my system to Ubuntu 19.04 and the whole environment is not working, currently I have:

$ node -v
v10.15.2

$ npm -v
5.8.0

Maybe I will try to downgrade them to a node v8.10.0 and npm 3.5.2, as before.

@sommerluk
Copy link
Collaborator

Does OSMF Operations already run the latest version?

Yes, operation is yet running Carto 1.2.0.

@sommerluk
Copy link
Collaborator

There are some warnings

This is a consequence of a change in CartoCSS which outputs now much more warnings than before, but still generates the very same XML result. Its consequences for openstreetmap-carto have been discussed in #3183 and it has been considered a non-issue.

@sommerluk
Copy link
Collaborator

Closing as we use higher Mapnik and Kosmtik versions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants