Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not put highway numbers exactly on overpasses or junctions #3219

Closed
jidanni opened this issue May 6, 2018 · 19 comments
Closed

Please do not put highway numbers exactly on overpasses or junctions #3219

jidanni opened this issue May 6, 2018 · 19 comments
Labels
roads wontfix-unfeasible Issues closed because of lack of suitable solution

Comments

@jidanni
Copy link

jidanni commented May 6, 2018

Why does the program often insist on putting highway numbers exactly on top of
overpasses?
1

Please have it notice that this is an overpass, and put it very clearly to
the right or left etc.

All it is doing is increasing the confusion as to which road is which.

Sure, we should know that the road on top is the road it is talking
about. But OK we are not that smart. So please still move them to the
side. Yes we should zoom in and out to get a different view. Problem
solved. But then again we are not that smart.
https://www.openstreetmap.org/#map=15/24.8489/121.2010

@kocio-pl kocio-pl added the roads label May 6, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone May 6, 2018
@sommerluk
Copy link
Collaborator

As far as I know, this is technically not possible with our current rendering software stack.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

Furthermore I have no problem sorting the things out, because shield colors are different.

@jidanni
Copy link
Author

jidanni commented May 7, 2018

What if one day, the shield colors are the same?

I don't know of any other paper, or on-line map that ever has done this. Nor any cartographer.

I don't think that closing the bug will help get this solved.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

The best thing to help is to write the code that could solve it while not introducing some other problems. If you know how to do it, just please try, because we don't.

"What if" is not the problem to solve. If someone will make the shield colors uniform, she will have to deal with this issue - but only then.

@matthijsmelissen
Copy link
Collaborator

I don't know of any other paper, or on-line map that ever has done this. Nor any cartographer.

Google and Bing also render shields on top of overpasses:

screen shot 2018-05-07 at 14 07 45

screen shot 2018-05-07 at 14 04 54

If you know how to do it, just please try, because we don't.

Exactly this. If you have an idea for a solution, feel free to.

@jidanni
Copy link
Author

jidanni commented May 7, 2018

Well please don't throw the bug away because there is no instant solution.
That is what bug trackers are for.
Sure, people would learn the basics, and eventually solve the bug,
but not if it is closed.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

I don't think that closing the bug will help get this solved.

I don't think that leaving bug open will help anything too. Bug tracker is just a tool to manage problems, open status is not a magic wand.

There are no guarantees to solve anything "eventually", there are rather big chances that it will just clutter the space. I am digging in the old tickets from time to time, so having such issues open really makes it harder to discover problems that can be solved.

@jidanni
Copy link
Author

jidanni commented May 7, 2018

Also even if the only problem is shield colors, one day Provincial Highway 7 will cross Provincial Highway 8. If you can manage not putting a 7 or an 8 smack in the middle of a flat intersection, then the same should be possible in three dimensions. Or just as a rule don't put them smack in the middle of any bridge.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

Still we see no solution and adding "what ifs" is not helping anything.

Do you have any code to solve it or even a hint how to code it?

@jidanni
Copy link
Author

jidanni commented May 7, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

We use SQL + CartoCSS here. You need to think in terms of selecting database values that mean "short bridge" for a start. Next thing is to look how the shields are placed in https://github.com/gravitystorm/openstreetmap-carto/blob/master/roads.mss.

@jidanni
Copy link
Author

jidanni commented May 7, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

In case of this style, especially roads, you have to debug, not simply write code:

  1. look at the road.mss code to find which variables are used for placing shields
  2. find the proper layer and code for selecting these data in project.mml
  3. modify it
  4. test if this change didn't introduce any other problems

It's not given that you will succeed, but this is a way to go.

@dieterdreist
Copy link

dieterdreist commented May 7, 2018 via email

@jidanni
Copy link
Author

jidanni commented May 7, 2018

I was thinking, I have never seen a marker rendered underneath a bridge or even partly underneath a bridge. Therefore perhaps add a pseudo bridge on top of a bridge then run the marker rendering algorithm and then remove the pseudo bridge. I will look at those files later.

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 7, 2018

Great. If you want to understand overall design of this style and test it a bit, it's good to start with these links:

@jidanni
Copy link
Author

jidanni commented May 9, 2018

I am sorry. I must maintain my role as just the bug reporter. All I can respectfully leave you with is a link,
https://www.google.com/search?q=common+cartographic+mistakes .

@matkoniecz matkoniecz added the wontfix-unfeasible Issues closed because of lack of suitable solution label May 9, 2018
@matkoniecz
Copy link
Contributor

matkoniecz commented May 9, 2018

Unfortunately I also expect that given technical limitations of this style it is unfixable. It would be great to see a PR fixing this (assuming that it is not introducing other worse cartographic or significant performance issues).

But unfortunately I would not expect this to be possible in general.

One thing that may help is #951 that would solve also other shield-related issues. Stopgap solutions like not rendering shields on bridge ways may or may not help but I am not convinced that it is a good way to solve that.

@jidanni
Copy link
Author

jidanni commented Aug 4, 2019

X0

Here https://www.openstreetmap.org/#map=15/41.7697/-86.7312
to make it worse, it seems to be part of a single letter bigger road
system ("I", "M") when it is in fact on par with {"IL" "SR" "IN"} but
with just one letter. A problem that would go away when #508 is completed.)

Anyway if one is going to place a number in an ambiguous place, make
sure it is the bigger item's number, else it will make it seem the
bigger road must be called the smaller's number. (When making a map we
can ignore creeks, tiny road underpasses when placing a number, so the
reader might assume this is also the case, even though this is an overpass.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roads wontfix-unfeasible Issues closed because of lack of suitable solution
Projects
None yet
Development

No branches or pull requests

6 participants