Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more FAQs answers based on feedback (#1005) #1009

Open
wants to merge 4 commits into
base: source
Choose a base branch
from

Conversation

Itsaadarsh
Copy link

Closes #1005

Description

I've added more questions to the FAQs section as mentioned on the issue, I've mostly covered all the given question except the following :

Best Practices

  • How can I make part of my GraphQL API private?

Specification

  • Why doesn’t GraphQL have a wildcard field?

So kindly review them and let me know if any changes are required.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 23, 2021

CLA Signed

The committers are authorized under a signed CLA.

src/content/faq/BestPractices.md Outdated Show resolved Hide resolved
src/content/faq/GettingStarted.md Outdated Show resolved Hide resolved
src/content/faq/GettingStarted.md Outdated Show resolved Hide resolved
@benjie
Copy link
Member

benjie commented Feb 23, 2021

Thanks for this work @Itsaadarsh this is a great start 🙌

@Itsaadarsh
Copy link
Author

Hello there @benjie, I've made the changes as you suggested do check them out and let me know if anything else is needed.

Copy link
Contributor

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Itsaadarsh . Just made a couple of small comments and typo suggestions :)

src/content/faq/BestPractices.md Outdated Show resolved Hide resolved
src/content/faq/BestPractices.md Outdated Show resolved Hide resolved
src/content/faq/General.md Outdated Show resolved Hide resolved
Yes, graphql2chartjs is an open source tool that reshapes your GraphQL data as per the ChartJS API. This makes building charts as easy as simply making a GraphQL query. The idea behind this tool was to leverage GraphQL's realtime subscriptions to build realtime charts by restructuring the GraphQL data to a form that ChartJS expects and generate ChartJS compliant data object from your GraphQL response by simply adding a few aliases in your GraphQL query.

For more information on graphql2chartjs, check out their [documentation](https://github.com/hasura/graphql2chartjs).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a cool library. But I'm a little concerned that it was last updated in 2019 & has a few open issues suggesting that things aren't working. Do you have any experience with it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I haven't worked with this library yet. So do you want me to remove it?

src/content/faq/GettingStarted.md Outdated Show resolved Hide resolved
src/content/faq/GettingStarted.md Outdated Show resolved Hide resolved
src/content/faq/BestPractices.md Show resolved Hide resolved
@Itsaadarsh Itsaadarsh requested a review from benjie March 6, 2021 08:46
@Itsaadarsh
Copy link
Author

Hey, @benjie can you review this PR and let me know if something else needs to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write more FAQ answers based on feedback
4 participants