Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2022-12] Revise IsVariableUsageAllowed to forbid nullable variable with default usage in non-nullable list position #1337

Closed
benjie opened this issue Jul 8, 2023 · 2 comments
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Jul 8, 2023

Action: having default mode be the happy path which will require to spec text changes

Relates to: graphql/graphql-spec#1002

We should move IsVariableUsageAllowed as IsVariableUsageAllowedLegacy in an appendix (or an addendum within the section) and add a new IsVariableUsageAllowed that turns this issue from a runtime error to a validation error. Use IsVariableUsageAllowedLegacy if you need to support legacy queries.

Video: https://youtu.be/nkPn-F_UBJo?list=PLP1igyLx8foH30_sDnEZnxV_8pYW3SDtb&t=2702
Actual action item timestamp: https://youtu.be/nkPn-F_UBJo?list=PLP1igyLx8foH30_sDnEZnxV_8pYW3SDtb&t=3452


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie added this to To do in Actions 2022-12 via automation Jul 8, 2023
@benjie benjie added the stale label Oct 11, 2023
@benjie benjie added Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. and removed stale labels Nov 10, 2023
@benjie
Copy link
Member Author

benjie commented Nov 10, 2023

Spec changes: graphql/graphql-spec#1059

Added to the WG meeting next week.

@benjie benjie self-assigned this Nov 16, 2023
@benjie
Copy link
Member Author

benjie commented Dec 7, 2023

Discussed at today's WG; closing 👍

@benjie benjie closed this as completed Dec 7, 2023
Actions 2022-12 automation moved this from To do to Done Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
Development

No branches or pull requests

1 participant