Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the query property really be required? #250

Closed
michaelstaib opened this issue Apr 13, 2023 · 1 comment
Closed

Should the query property really be required? #250

michaelstaib opened this issue Apr 13, 2023 · 1 comment

Comments

@michaelstaib
Copy link
Member

With the last commit we made the query property required. When you work with persisted queries this prop is omitted and a hash is used instead. In the past GraphQL servers would have a separate prop like id, hash or others to provide the query hash. In past discussions we decided that this could be better stored on the extensions map. But for this we need to have query optional whenever extensions is provided.

A public example of storing the hash on extensions is for instance Apollo.

@benjie @spawnia

@michaelstaib
Copy link
Member Author

michaelstaib commented Apr 13, 2023

OK ... saw that this discussion is already being held on #216 .... closing this as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant