Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Optional typing on PageInfo hasPreviousPage and hasNextPage #30

Closed
markedwards opened this issue Apr 30, 2020 · 3 comments
Closed

Incorrect Optional typing on PageInfo hasPreviousPage and hasNextPage #30

markedwards opened this issue Apr 30, 2020 · 3 comments
Assignees
@Cito

Comments

@markedwards
Copy link
Contributor

markedwards commented Apr 30, 2020 •
edited

The typing of PageInfo.hasPreviousPage and PageInfo.hasNextPage appears to be incorrectly indicated as Optional[bool] here.

Is there a reason for this, or can it be fixed?
@Cito
Copy link
Member

Cito commented May 3, 2020

The reason is that relay-py is a direct port of relay-js which defines them as optional. I have now asked whether it can be fixed there, then we can port it back here.

@Cito Cito self-assigned this May 3, 2020
@Cito Cito added the pending Waiting for other issues to move forward label May 3, 2020
@markedwards
Copy link
Contributor Author

Thanks @Cito.

@Cito Cito mentioned this issue Mar 19, 2021
Closed
Cito added a commit that referenced this issue Mar 19, 2021
@Cito
hasPrevious/NextPage should not be optional (#30)
ffdaf3f 
Replicates graphql/graphql-relay-js@91a8525
@Cito Cito removed the pending Waiting for other issues to move forward label Mar 19, 2021
@Cito
Copy link
Member

Cito commented Mar 19, 2021

This has now been fixed upstream and here (to be released).

@Cito Cito closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cito Cito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markedwards @Cito