Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Automated Escrow deposit for sender not signer #90

Open
hopeyen opened this issue May 9, 2024 · 0 comments
Open

Fix: Automated Escrow deposit for sender not signer #90

hopeyen opened this issue May 9, 2024 · 0 comments
Labels
p3 Low priority size:small Small type:refactor Changes not visible to users

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented May 9, 2024

Problem statement

Realising that the downloader must run as a signer and not sender, the previous --max-auto-deposit submits GRT approval and Escrow deposit ran during download would be done on behave of the signer, which is incorrect.

Expectation proposal

While it is fairly easy to run the CLI command manually with the sender wallet, it would be good to let downloader take in an secondary mnemonic/private such that manual work is not needed.
Update auto payment to use the sender wallet.

@hopeyen hopeyen added type:refactor Changes not visible to users size:small Small p3 Low priority labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Low priority size:small Small type:refactor Changes not visible to users
Projects
None yet
Development

No branches or pull requests

1 participant