Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Black/White List to Block/Allow list #939

Open
jaimegago opened this issue Oct 24, 2022 · 4 comments
Open

Change Black/White List to Block/Allow list #939

jaimegago opened this issue Oct 24, 2022 · 4 comments
Labels

Comments

@jaimegago
Copy link

jaimegago commented Oct 24, 2022

I know the etymology of blacklist/whitelist has nothing to do with racism, yet it adds another stone to the "black is bad/white is good" edifice. So why not change it since we can, it's fairly simple and it doesn't cost anyone anything but to change a technical name?
Also quite frankly as far as software engineering naming goes, Block/Allow are quite better at carrying the meaning of what that code does than Black/White aren't they ;-).

@deniszh
Copy link
Member

deniszh commented Oct 24, 2022

Related PRs - graphite-project/graphite-web#1700 and #591 , probably they can be rebased on latest codebase and merged.

@deniszh deniszh added the pinned label Oct 24, 2022
@jaimegago
Copy link
Author

Ah! The change is ready to go, nice!

@deniszh
Copy link
Member

deniszh commented Oct 24, 2022

well, not exactly, it's from 2016, will require some work

@deniszh
Copy link
Member

deniszh commented Feb 19, 2023

Ok, I created graphite-project/graphite-web#2808 and #943 and tried to rebase / fixed tests, but looks like it's require much more work then I anticipated. :(
So, unfortunately, parking this for now, maybe someone else can contribute or I'll find time bit later. Thanks for understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants