Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roadmap] Graph4NLP v0.6 plan #496

Open
AlanSwift opened this issue Feb 13, 2022 · 17 comments
Open

[Roadmap] Graph4NLP v0.6 plan #496

AlanSwift opened this issue Feb 13, 2022 · 17 comments

Comments

@AlanSwift
Copy link
Contributor

AlanSwift commented Feb 13, 2022

Task List

  • [New Feature] A brand new configuration system based on OmegaConf.
  • [Feature] Upgrade stanford CoreNLP to Stanza.
  • [Feature] Improve the dataset custermize experiments.
  • [Feature] Add relational GNN support.
@AlanSwift AlanSwift pinned this issue Feb 13, 2022
@nashid
Copy link

nashid commented Feb 15, 2022

@AlanSwift looking forward to the relational GNN support.

By the way, without the support to run in a multiple-GPU environment, not sure how this library could be useful for large datasets. Do you plan to add support for multiple GPUs?

@ramsey-coding
Copy link

ramsey-coding commented Mar 9, 2022

@AlanSwift @hugochan @teddylfwu @SaizhuoWang this is a fantastic library. And to the best of my knowledge, this is the only GNN library that is NLP focused.

Would like to give some feedback about the library:

  • I think the effort for the library is misdirected. For example, the library has severe bug like Beam search is broken. I think any Major bug should be prioritized as that completely limits the use of the library.

  • Even if I look into the current Roadmap, I see effort is seriously misguided. The only major feature I see is adding relational GNN support which is great. But what's the point of so many bookkeeping tasks like add a brand new configuration system based on OmegaConf. These are just busy work that does not do much for an average user of the library. I am pretty sure a lot of effort would then be directed just to modify/update existing examples and to use this new configuration system.

Unfortunately that does not do much for a typical user. No one really cares that you are using OmegaConf configuration library. What matters is adding actual useful feature into the library. And it is extremely important to ensure the features that are already into the library actually works and there is no bug. Lets say you added R-GCN and it is buggy. Then the priority should be to fix that bug instead of updating a configuration system.

If there is a major bug, there is no point of adding more and more features into the library. To summarize, for any software engineering tasks, there needs to be a balance between what is "actual feature" vs "doing chores" (like updating configuration system) which does not add much to the library.

This is just my 2 cents. And again - thanks for this fantastic library.

@ramsey-coding
Copy link

ramsey-coding commented Mar 9, 2022

@AlanSwift @hugochan @teddylfwu @SaizhuoWang Furthermore, I see in the description work on configuration system is stated as a New Feature:

[New Feature] A brand new configuration system based on OmegaConf

This is not a feature. Feature is something that adds value to a project. So the understanding of what is called as a "feature" is wrong. It should be stated "Code Debt" or "Maintenance" work.

@schenglee schenglee unpinned this issue Apr 10, 2022
@schenglee schenglee pinned this issue Apr 10, 2022
@nashid
Copy link

nashid commented Jun 16, 2022

@AlanSwift wondering when the RGCN implementation would be available?

@smith-co
Copy link

When the new release would be announced?

@code-rex1
Copy link

@AlanSwift @hugochan @teddylfwu @SaizhuoWang @xiao03 wondering when this library version would be released 🙏 🙏 🙏 ?

@AlanSwift
Copy link
Contributor Author

AlanSwift commented Aug 5, 2022

Reply to all: We will have a meeting this weekend. I think the new release will come in two weeks. Really sorry for the delay.

@code-rex1
Copy link

@AlanSwift this is a great library for GNN. Looking forward to the release specially the implementation of RGCN.

Also if you could support transformer in the future, would a great feature for this useful library.

@AlanSwift
Copy link
Contributor Author

AlanSwift commented Aug 6, 2022

Yes. The full support of the transformer is on schedule. The transformer encoder will release in the next coming version. And the transformer decoder will come soon (on test). @code-rex1

@smith-co
Copy link

smith-co commented Sep 3, 2022

@AlanSwift looking forward to use the transformer encoder 🥇. When would it be release?

@smith-co
Copy link

Wondering what's the tentative timeline for this release.

@AlanSwift
Copy link
Contributor Author

We are still discussing it #578. We still need 2-3 weeks to make it ready since it covers many features. @smith-co

@nashid
Copy link

nashid commented Nov 4, 2022

@AlanSwift wondering when the RGCN implementation would be available?

@AlanSwift
Copy link
Contributor Author

@AlanSwift wondering when the RGCN implementation would be available?

We have almost finished the implementation and currently are testing on down tasks. We are sorry we delayed too much time since it is a big feature migration from the homogeneous graph to the heterogeneous graph.

@nashid
Copy link

nashid commented Nov 19, 2022

Really looking forward to it. Thanks @AlanSwift

@dmbs335
Copy link

dmbs335 commented Jan 9, 2023

@AlanSwift Could you please tell me when would new version be released?

@nashid
Copy link

nashid commented Apr 22, 2023

Wondering is there a further update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants