Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate domain in HostName entry if os.Hostname() already contains domain #77

Open
segfault16 opened this issue Oct 23, 2020 · 0 comments · May be fixed by #78
Open

Duplicate domain in HostName entry if os.Hostname() already contains domain #77

segfault16 opened this issue Oct 23, 2020 · 0 comments · May be fixed by #78

Comments

@segfault16
Copy link

Given the examples I see the following output on MacOS 10.14.6

# go run examples/register/server.go --wait 0     
2020/10/23 05:30:54 Published service:
2020/10/23 05:30:54 - Name: GoZeroconfGo
2020/10/23 05:30:54 - Type: _workstation._tcp
2020/10/23 05:30:54 - Domain: local.
2020/10/23 05:30:54 - Port: 42424

# go run examples/resolv/client.go
2020/10/23 05:31:34 &{{GoZeroconfGo _workstation._tcp [] local _workstation._tcp.local. GoZeroconfGo._workstation._tcp.local. _services._dns-sd._udp.local.} studios-iMac.local.local. 42424 [txtv=0 lo=1 la=2] 3200 [192.168.9.102] [fe80::1 2a02:8070:d380:5900:2b:59f6:77ac:63d7 2a02:8070:d380:5900:4c95:9246:35b5:3886 fe80::f1ec:e3e6:f4ad:5413]}
2020/10/23 05:31:36 No more entries.

I expected to HostName of the entry to be studios-iMac.local. instead of studios-iMac.local.local..

The hostname returned by the kernel at https://github.com/grandcat/zeroconf/blob/master/server.go#L46 is studios-iMac.local and the domain suffix is added at https://github.com/grandcat/zeroconf/blob/master/server.go#L53.
@segfault16 segfault16 linked a pull request Oct 23, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix adding domain to HostName segfault16/zeroconf
1 participant
@segfault16