Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.Shutdown() should print errors #72

Open
leventov opened this issue May 21, 2020 · 0 comments · May be fixed by #87
Open

server.Shutdown() should print errors #72

leventov opened this issue May 21, 2020 · 0 comments · May be fixed by #87

Comments

@leventov
Copy link

zeroconf/server.go

Lines 195 to 198 in c2d1b41

// Shutdown closes all udp connections and unregisters the service
func (s *Server) Shutdown() {
s.shutdown()
}

Should be

if err := s.shutdown(); err != nil {
  log.Printf("Error shutting down the server: %v", err)
}

shutdown() itself should propagate or print errors from closing ipv4conn and ipv6conn.

This was referenced Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant