Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot browse different domain than "local". #37

Open
stephan57160 opened this issue Jun 7, 2018 · 3 comments · May be fixed by #46
Open

Cannot browse different domain than "local". #37

stephan57160 opened this issue Jun 7, 2018 · 3 comments · May be fixed by #46

Comments

@stephan57160
Copy link

stephan57160 commented Jun 7, 2018

I managed to create a domain ("XXX.local"), where all my machines are registered, with AVAHI configuration. I'm able to see all of them with avahi-browse, no issue there.

None is listed with "client -domain "XXX.local".
(I compiled the "examples/resolv/client.go" as "client")

Adding some traces in the code, and trying to see where/how this can be fixed.
Possibly, a proposal for a fix can come before end of this week.

@grandcat
Copy link
Owner

grandcat commented Jun 7, 2018

Have you checked that the domain is set correctly to the one you are expecting?
By default, the example client assumes _workstation._tcp.

@stephan57160
Copy link
Author

stephan57160 commented Jun 7, 2018

Yes, service is also set as _workstation._tcp on the other machines.

I had a look in the code and added a bunch of traces.
Then, I found that the DNS answers are filtered out in "mainloop()", in one or the other tests on params.ServiceInstanceName or HasSuffix.

Finally, I passed "domain" to build the default params, in 2 places, like :

params := defaultParams(service, domain)

and obviously, defaultParams() is changed accordingly:

	func defaultParams(service, domain string) *LookupParams {
		return NewLookupParams("", service, domain, make(chan *ServiceEntry))
	}

This works fine for my case, but I'm unable to run a complete test plan.

@vtolstov
Copy link

vtolstov commented Sep 3, 2018

@grandcat what do you think?

celebdor pushed a commit to celebdor/zeroconf that referenced this issue Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants