Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServeDir and SPAIndex conflict: NotFound ignored due to fasthttp.FS #37

Open
aleksei0807 opened this issue Jul 27, 2018 · 2 comments
Open

Comments

@aleksei0807
Copy link
Contributor

Expected Behavior

ServeDir() serves files from directory and when gets 404 it should call NotFound() instead of bare fasthttp processing

Current Behavior

ServeDir() ignores NotFound() due to fasthttp.FS usage

Possible Solution

Embed fasthttp.FS, fix NotFound() processing, replace it in ServeDir etc.

Steps to Reproduce (for bugs)

See first 3s version

Context

Serving files in SPA

Your Environment

  • Version used: 1.1.0-rc15
  • Environment name and version (e.g. Go1.9 on CentOS 7, kernel 4.11.2): go version go1.10.2 darwin/amd64; Darwin Kernel Version 17.5.0: Fri Apr 13 19:32:32 PDT 2018; root:xnu-4570.51.2~1/RELEASE_X86_64 x86_64
  • Server type and version: -
  • Operating System and version: MacOS 10.13.4
  • Link to your project: https://github.com/gramework/3s
@toby3d

This comment has been minimized.

@kirillDanshin
Copy link
Member

@toby3d no, that's another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants