Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove library_flags & only specify c_library_flags where needed #41

Merged
merged 2 commits into from Jan 20, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 20, 2022

Ports the flag fixes to version 103

Additional conventional commit messages to apply:

fix: Run cmake build with -j4 for faster builds
chore: Add the mingw path to the esy buildEnv & exportedEnv
chore: Add OCaml 4.13.1 to the Opam CI matrix
chore: Widen esy ocaml version & update devDeps
chore: Update README to discuss flags

Co-authored-by: Eduardo Rafael <theeduardorfs@gmail.com>

phated and others added 2 commits January 20, 2022 14:27
…#37)

fix: Run cmake build with -j4 for faster builds
chore: Add the mingw path to the esy buildEnv & exportedEnv
chore: Add OCaml 4.13.1 to the Opam CI matrix
chore: Widen esy ocaml version & update devDeps
chore: Update README to discuss flags

Co-authored-by: Eduardo Rafael <theeduardorfs@gmail.com>
@phated phated requested a review from ospencer January 20, 2022 22:56
@phated phated merged commit a89fad6 into main Jan 20, 2022
@phated phated deleted the phated/port-flags branch January 20, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants