fix: Use double dash before -j4 to always pass through #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
Jan 20, 2022
phated
added a commit
that referenced
this pull request
Jan 20, 2022
phated
added a commit
that referenced
this pull request
Jan 20, 2022
…#41) fix: Run cmake build with -j4 for faster builds chore: Add the mingw path to the esy buildEnv & exportedEnv chore: Add OCaml 4.13.1 to the Opam CI matrix chore: Widen esy ocaml version & update devDeps chore: Update README to discuss flags fix: Use double dash before -j4 to always pass through (#39) Co-authored-by: Eduardo Rafael <theeduardorfs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't matter for most systems, but the opam CI failed on ubuntu 18.04 with an older cmake because the
-j4wasn't passed through with--before it.