Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure project can build with Opam on Windows #33

Merged
merged 1 commit into from Jan 18, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 17, 2022

This actually relies on fixes in conf-python-3 and conf-cmake to land in the mingw repository, so draft for now.

This is all the changes to get this project working from opam on windows.

@phated phated changed the title WIP: Getting opam + windows working fix: Ensure project can build with Opam on Windows Jan 18, 2022
@phated phated marked this pull request as ready for review January 18, 2022 20:00
@phated
Copy link
Member Author

phated commented Jan 18, 2022

Looks like those fixes were merged into the mingw repository. Running the CI now, but this should be ready.

@phated phated requested a review from ospencer January 18, 2022 20:01
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy CI!

@phated phated merged commit e6070de into v102 Jan 18, 2022
@phated phated deleted the phated/opam-windows branch January 18, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants