Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Bump binaryen to version_103 #24

Merged
merged 4 commits into from Jan 11, 2022
Merged

feat!: Bump binaryen to version_103 #24

merged 4 commits into from Jan 11, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 10, 2022

This bumps binaryen for the version_103 tag. Doesn't seem like any other change is necessary.

@phated phated requested a review from ospencer January 10, 2022 20:57
@phated
Copy link
Member Author

phated commented Jan 11, 2022

Needed to add CMAKE_CXX_FLAGS so it doesn't crash on the gcc that esy provides on windows.

@phated phated merged commit aa8a42d into main Jan 11, 2022
@phated phated deleted the phated/v103 branch January 11, 2022 20:20
@github-actions github-actions bot mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phated @ospencer