feat: Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my initial implementation of libbinaryen packaged for opam. It uses a lot of the work that @ospencer originally did for binaryen.ml but we have a working cmake on Windows now when installing with esy鈥攐pam, as always, is a whole other story...
Additionally, I figured out how to build Binaryen inside an OCaml environment in both esy & opam on Windows (take all of my tears 馃槶 )
I added a smoke test to this repository to show that bindings can actually be written, which helped me find a bunch of problems on Windows. But I also have Binaryen.ml using this as a resolution to test everything is working at grain-lang/binaryen.ml#113
I still need to add the grainbot automation and I need to use https://github.com/googleapis/release-please#how-do-i-change-the-version-number when merging this to stick to the v101.0.0 version to align with Binaryen