Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grainfmt: Consider wrapping multiline when conditions in parens #2035

Open
phated opened this issue Feb 19, 2024 · 1 comment
Open

Grainfmt: Consider wrapping multiline when conditions in parens #2035

phated opened this issue Feb 19, 2024 · 1 comment

Comments

@phated
Copy link
Member

phated commented Feb 19, 2024

In #1976, we removed parens around multiple expressions in when conditions. We should consider adding them back and breaking nicer.
@phated phated mentioned this issue Feb 19, 2024
Merged
@ospencer
Copy link
Member

ospencer commented Apr 5, 2024

I didn't love the parens, but we could look into how the expressions break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phated @ospencer