Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Make number tests use isClose #2033

Open
spotandjake opened this issue Feb 19, 2024 · 2 comments
Open

Tests: Make number tests use isClose #2033

spotandjake opened this issue Feb 19, 2024 · 2 comments
Labels
good first issue stdlib

Comments

@spotandjake
Copy link
Member

There are a lot of cases in the Number libraries tests that we use < and then a > comparison to check approximate equal such as with gamma and trig functions. We should instead use the Number.isClose function.
@AdemOdza
Copy link

I would love to pick this up if no one else has

@ospencer
Copy link
Member

@AdemOdza Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ospencer @spotandjake @AdemOdza