feat(compiler): Inline all primitives #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peblair
approved these changes
Dec 24, 2021
| [arg], | ||
| ) => | ||
| transl_comp_expression({...e, exp_desc: TExpPrim1(Not, arg)}) | ||
| | TExpApp({exp_desc: TExpIdent(_, _, {val_kind: TValPrim(prim)})}, args) => |
marcusroberts
approved these changes
Dec 30, 2021
ospencer
force-pushed
the
oscar/inline-all-primitives
branch
from
b408841
to
7fc6861
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only inline some primitives. This PR inlines them all. This also allows us to mostly remove the
inline_wasmoptimization, but we can't completely get rid of it because of--no-bulk-memory鈥攚e could, but that means we'd need to write the polyfill implementations ofmemory_fillandmemory_copyin pure wasm in the compiler (which I didn't want to do right now 馃槄).