Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conversion of i64 literals #96

Merged
merged 5 commits into from Apr 2, 2021
Merged

fix: Conversion of i64 literals #96

merged 5 commits into from Apr 2, 2021

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Apr 2, 2021

No description provided.

@ospencer ospencer requested a review from a team April 2, 2021 06:47
@ospencer ospencer self-assigned this Apr 2, 2021
@phated
Copy link
Member

phated commented Apr 2, 2021

@ospencer you are an absolute wizard! Do you have a good way for us to test this in this repo's tests?

@ospencer
Copy link
Member Author

ospencer commented Apr 2, 2021

Could just add a global export that's just some int64 value and verify that it's correct in the test.

Copy link
Member Author

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! <3

@phated phated merged commit 00b7093 into master Apr 2, 2021
@phated phated deleted the fix-i64-literals branch April 2, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants