Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Binaryen 100 #75

Merged
merged 1 commit into from Mar 5, 2021
Merged

feat: Upgrade to Binaryen 100 #75

merged 1 commit into from Mar 5, 2021

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Mar 5, 2021

BREAKING CHANGE: Table name must now be provided to the Expression.call_indirect and Expression.return_call_indirect instructions.

BREAKING CHANGE: Table name must now be provided to the `Expression.call_indirect` and `Expression.return_call_indirect` instructions.
@ospencer ospencer requested a review from a team March 5, 2021 04:17
@ospencer ospencer self-assigned this Mar 5, 2021
@ospencer
Copy link
Member Author

ospencer commented Mar 5, 2021

Tests pass locally when this is linked into the Grain compiler (with breaking changes/other issues resolved).

Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions

src/binaryen_stubs_expressions.c Show resolved Hide resolved
src/binaryen_stubs_expressions.c Show resolved Hide resolved
@ospencer ospencer merged commit d59f5f9 into master Mar 5, 2021
@ospencer ospencer deleted the binaryen_100 branch March 5, 2021 18:12
@phated phated mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants