Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix markdown escaping for opam release #72

Merged
merged 1 commit into from Feb 25, 2021
Merged

ci: fix markdown escaping for opam release #72

merged 1 commit into from Feb 25, 2021

Conversation

phated
Copy link
Member

@phated phated commented Feb 24, 2021

I don't actually know if this will work.

@phated phated requested a review from ospencer February 24, 2021 23:14
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's got a fair chance at working. I tried it in my terminal and those single quotes make all the difference. I think it might have an issue if there's single quotes in the input though, but I can't for the life of me find any info on that.

But this seems great to me!

@phated
Copy link
Member Author

phated commented Feb 25, 2021

Yeah, my only unknown is whether the github variable inject does a direct inline because then a single quote will close the message. It turns out that escaping a single quote in a single-quoted string in bash is a nightmare.

@phated phated merged commit a2e6052 into master Feb 25, 2021
@phated phated deleted the fix-escaping branch February 25, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants