Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opam] Change the pattern for pulling down vendored files #42

Closed
phated opened this issue Dec 21, 2020 · 2 comments · Fixed by #113
Closed

[opam] Change the pattern for pulling down vendored files #42

phated opened this issue Dec 21, 2020 · 2 comments · Fixed by #113
Assignees

Comments

@phated
Copy link
Member

phated commented Dec 21, 2020

There was a really cool pattern I was introduced to in https://github.com/ocaml/opam-repository/pull/17776/files where there can be an opam file that just fetches a prebuilt dependency. We should do that for binaryen instead of shoving them inside this package.

@phated phated self-assigned this Dec 21, 2020
@ospencer
Copy link
Member

That'd be sick!

@phated
Copy link
Member Author

phated commented Jan 13, 2022

This pattern doesn't work for esy so opting for always building from source. Ref #113

@phated phated linked a pull request Jan 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants