Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build from source when a prebuilt artifact is not available in project #38

Closed
phated opened this issue Nov 25, 2020 · 2 comments · Fixed by #113
Closed

Build from source when a prebuilt artifact is not available in project #38

phated opened this issue Nov 25, 2020 · 2 comments · Fixed by #113

Comments

@phated
Copy link
Member

phated commented Nov 25, 2020

Currently, we vendor for 64bit Windows/Linux/Mac, but we should fallback to building from source when one of those doesn't work.

We removed that because esy-cmake/esy-python/esy-bash were broken or outdated, but there is effort to get those fixed upstream.

Eventually, I think we will have esy-binaryen and conf-binaryen for esy and opam respectively.
@phated phated mentioned this issue Nov 25, 2020
Merged
@ng-marcus
Copy link

@phated I was just trying a MacOS ARM64 build of Grain and got stuck on the libbinaryen.a file being only x86_64 for MacOS, as per this issue.

How do I build the file I need?

@phated
Copy link
Member Author

phated commented Jan 13, 2022

Opting for always building from source. Ref #113

@phated phated linked a pull request Jan 13, 2022 that will close this issue
feat!: Switch to libbinaryen dependency #113
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Switch to libbinaryen dependency grain-lang/binaryen.ml
2 participants
@phated @ng-marcus