Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle JS global in non-node environments #125

Merged
merged 1 commit into from Jan 24, 2022
Merged

fix: Handle JS global in non-node environments #125

merged 1 commit into from Jan 24, 2022

Conversation

phated
Copy link
Member

@phated phated commented Jan 24, 2022

I'm trying some tweaks for our JSOO build in non-nodejs environments.

@phated phated marked this pull request as ready for review January 24, 2022 21:05
@phated phated requested a review from ospencer January 24, 2022 21:05
@phated
Copy link
Member Author

phated commented Jan 24, 2022

This should be ready for review. It runs successfully in CI & I tested it in Grain both in nodejs and in my browser work.

marcusroberts
marcusroberts approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@marcusroberts marcusroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@phated phated merged commit 74e94fe into master Jan 24, 2022
@phated phated deleted the phated/js-global branch January 24, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ospencer ospencer ospencer approved these changes

@marcusroberts marcusroberts marcusroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phated @ospencer @marcusroberts