feat: Upgrade to libbinaryen v102 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/libbinaryen_102
branch
from
6c79e59
to
49741c5
Compare
|
Here's the diff between I believe I touched on the big changes, but still want @ospencer to review the diff to see if we should be adding anything else. |
|
The opam builds should fail, but esy should pass (which will highlight that the libbinaryen patch is working). |
|
We're not going to be merging it, but I wanted to ensure that the native implementation was working when linked into Grain (since it has a much larger test suite). I pushed that branch to https://github.com/grain-lang/grain/tree/phated/binaryen_102 |
ospencer
approved these changes
Jan 14, 2022
phated
commented
Jan 15, 2022
phated
commented
Jan 15, 2022
phated
commented
Jan 15, 2022
phated
force-pushed
the
phated/libbinaryen_102
branch
from
80a67bb
to
af33a6e
Compare
phated
force-pushed
the
phated/libbinaryen_102
branch
from
25c0cd6
to
b90b6c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades libbinaryen to v102 (using a resolution from grain-lang/libbinaryen#28).
We need to update our bindings so they work with this new version. cc @ospencer to help with the C bindings.