feat!: Switch to libbinaryen dependency #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/libbinaryen-package
branch
2 times, most recently
from
2adfc4b
to
9b7f642
Compare
phated
commented
Dec 13, 2021
phated
force-pushed
the
phated/libbinaryen-package
branch
from
c41b0fd
to
97c3cd9
Compare
phated
force-pushed
the
phated/libbinaryen-package
branch
from
97c3cd9
to
6e8aa0e
Compare
phated
changed the title
ospencer
approved these changes
Jan 12, 2022
This was referenced Jan 13, 2022
This was
linked to
issues
Jan 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work-in-progress on removing our vendored Binaryen artifacts to instead depend on libbinaryen. The goal is to build Binaryen from source so we can work on any platform instead of only x86_64 platforms.
Currently, there are some hacks with resolutions to resolve the libbinaryen repo that I'm working on, and I haven't removed the artifacts from the repository yet.