feat!: Require Ocaml 4.12 & update depedencies to support it #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
commented
Sep 14, 2021
| with: | ||
| ocaml-version: ${{ matrix.ocaml-version }} | ||
|
|
||
| # I'm not exactly sure what the `opam pin` does | ||
| - name: Setup environment | ||
| run: | | ||
| opam pin add binaryen.dev . --no-action | ||
| opam depext binaryen --yes --with-doc --with-test |
There was a problem hiding this comment.
MacOS no longer gets depext installed (by default?). Luckily we don't need it.
phated
commented
Sep 14, 2021
| @@ -21,15 +21,14 @@ jobs: | |||
| submodules: 'recursive' | |||
|
|
|||
| - name: Setup OCaml ${{ matrix.ocaml-version }} | |||
| uses: avsm/setup-ocaml@v1 | |||
| uses: ocaml/setup-ocaml@v1.1.12 | |||
phated
commented
Sep 14, 2021
| "@opam/ocamlformat": "^0.15.0", | ||
| "@opam/ocaml-lsp-server": "^1.1.0" | ||
| "@opam/js_of_ocaml-compiler": "^3.10.0", | ||
| "@opam/ocamlformat": "0.18.0", |
There was a problem hiding this comment.
0.19.0 doesn't work on windows because they added ocp-indent to their deps which tries to do things with symlinks or something. Pin to 0.18 which supports ocaml 4.12
phated
commented
Sep 14, 2021
Comment on lines
-11
to
-16
| caml_alloc_some(value v) { | ||
| CAMLparam1(v); | ||
| value some = caml_alloc_small(1, 0); | ||
| Store_field(some, 0, v); | ||
| CAMLreturn(some); | ||
| } |
There was a problem hiding this comment.
OCaml 4.12 added this to the core
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally have CI passing. It's really frustrating to come back to projects and the CI has rotted. 馃槶