Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference types #101

Merged
merged 4 commits into from May 9, 2021
Merged

Reference types #101

merged 4 commits into from May 9, 2021

Conversation

jozanza
Copy link
Contributor

@jozanza jozanza commented Apr 23, 2021

Getting this PR going. Adding support for reference types as described in #100

Closes #100

.gitignore Show resolved Hide resolved
@phated
Copy link
Member

phated commented May 9, 2021

@jozanza @ospencer is there a reason this is still a draft? Just waiting for the other stuff to land?

@jozanza jozanza marked this pull request as ready for review May 9, 2021 03:58
@jozanza
Copy link
Contributor Author

jozanza commented May 9, 2021

@phated No reason! I just changed it to "Ready for Review" 👍🏽

@phated phated changed the base branch from binaryen-additonal_operations to master May 9, 2021 22:19
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to rebase on master and make a fix to the tests, but LGTM now!

Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@phated phated merged commit 5058492 into grain-lang:master May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reference types
3 participants