Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
feat!: Switch to libbinaryen dependency (#113)
feat: Depend on libbinaryen
chore: Use ubuntu-latest in opam CI
chore!: Mention implicit python dependency in the docs
  • Loading branch information
phated committed Jan 13, 2022
1 parent f5e226f commit 59874ce
Show file tree
Hide file tree
Showing 39 changed files with 490 additions and 3,283 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/opam.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-18.04, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
ocaml-compiler: [4.12.0]

steps:
Expand Down
6 changes: 6 additions & 0 deletions README.md
Expand Up @@ -42,6 +42,12 @@ This project aims to provide full feature parity with the [Binaryen C API](https

None of these are particularly challenging to create bindings for—they just haven't been written yet. If you need anything that's missing, feel free to open a PR.

## Python dependency

When using this package with `esy`, you'll need to ensure that a `python` executable exists in one of these locations: `/usr/local/bin/python`, `/usr/bin/python`, `/bin/python`, `/usr/sbin/python`, or `/sbin/python`. Esy will only look for python in those locations, and it is not provided for you in the sandbox.

**Note:** This implicit dependency will be removed in a future version.

## MacOS C++ Compiler

When including this library in your `dune` MacOS executables, you'll need to specify `-cc clang++` in your `(ocamlopt_flags)` stanza. This is required because Binaryen will throw errors for itself to catch and using `clang++` is the only way to handle them correctly. You can find more info on this [ocaml issue](https://github.com/ocaml/ocaml/issues/10423).
Expand Down
2 changes: 1 addition & 1 deletion binaryen.opam
Expand Up @@ -18,5 +18,5 @@ depends: [
"js_of_ocaml" {>= "3.10.0"}
"js_of_ocaml-ppx" {>= "3.10.0"}
"js_of_ocaml-compiler" {>= "3.10.0"}
"libbinaryen" {>= "101.0.1" < "102.0.0"}
]
available: arch = "x86_64" & (os = "linux" | os = "macos" | os = "win32")
472 changes: 251 additions & 221 deletions esy.lock/index.json

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 0 additions & 30 deletions esy.lock/opam/dot-merlin-reader.4.1/opam

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 59874ce

Please sign in to comment.