Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail typechecking for functions passed to bigslice.Func that take func and channel arguments #115

Open
jcharum opened this issue Nov 5, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jcharum
Copy link
Contributor

jcharum commented Nov 5, 2020

Right now, these aren't caught until we try to gob-encode. Consider failing faster in type-checking to avoid too much confusion/loss when it works with local execution.

@jcharum jcharum added the good first issue Good for newcomers label Nov 5, 2020
@ogi-iii
Copy link

ogi-iii commented Aug 7, 2022

Can I ask more details of this issue?

I think I should fix the function "Func(fn interface{}) *FuncValue {...}" in bigslice/func.go (from line 152), but what kind of typechecking should I add this code?
Could you give me an example of failed typechecking pattern?

I would like to work on this issue as my first experience of OSS committer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants