Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metrics processing and aggregation #2

Closed
yorugac opened this issue Oct 29, 2021 · 0 comments · Fixed by #38
Closed

Improve metrics processing and aggregation #2

yorugac opened this issue Oct 29, 2021 · 0 comments · Fixed by #38

Comments

@yorugac
Copy link
Collaborator

yorugac commented Oct 29, 2021

The extension must send samples with values that would be understandable to remote agent. To achieve that, k6 aggregation methods of Sink interface are used. This leads to the following problems:

  1. Sink's Add and Format methods are not very efficient; additionally, Trend's Sink is not fit for such usage at all so ad-hoc optimizations must be used as is done here (related k6 issue)
  2. attempt to group samples for each metric into TimeSeries leads to losing data in tags / labels (related k6 issue)
  3. converting all samples into separate TimeSeries results, at best, in hitting early whatever usage limit is currently set at Prometheus

Since adding any kind of further pre-processing here might clash with the future work on Metric Refactoring at k6, improving these can be considered blocked for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant